xattr: default to weekly stability if missing#101
Merged
Conversation
This is the second part of #98. If the user didn't provide any interval via the new xattr API, assume weekly. Previously, we were using the fallback of (minimum stability)/2, which (1) is way too sensitive to churny outliers in the package set, and (2) doesn't really have a basis in what users are expressing. I'm converting users' intent of bothering to add an xattr here as them saying that it has _some_ amount of stability, which I'm semi-arbitrarily ballparking as 'weekly'. While we're here, tweak the README section on xattrs a bit more to reflect reality.
Semi-arbitrarily chosen value. But 10 feels like the point where you're probably doing this mechanically (e.g. mapping from a currently incompatible repo database) than by hand on specific files. If those components become a large part of your total component set, you really want to add stability information for better packing.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the xattr-based component implementation to use a default update interval of 7 days (weekly) when the user.update-interval xattr is missing, rather than defaulting to zero stability. The changes include updates to the documentation, logic for calculating component stability, and a new warning threshold for missing xattrs. A review comment suggests replacing a magic number in the tests with the newly defined UPDATE_INTERVAL_DEFAULT constant for better maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second part of #98. If the user didn't provide any interval via the new xattr API, assume weekly.
Previously, we were using the fallback of (minimum stability)/2, which (1) is way too sensitive to churny outliers in the package set, and (2) doesn't really have a basis in what users are expressing.
I'm converting users' intent of bothering to add an xattr here as them saying that it has some amount of stability, which I'm semi-arbitrarily ballparking as 'weekly'.
While we're here, tweak the README section on xattrs a bit more to reflect reality.