Merged
Conversation
`skopeo inspect` on container-storage images may or may not return compressed sizes rather than uncompressed sizes depending on how the image was imported. Switch to using the layer sizes in `podman history` if available, which is always going to be the uncompressed size. Ideally we'd always used a compressed size here since that's actually the data amount on the wire and that's what we're minimizing, but comparing compression possibly done by different compressors is awkward. But most of all though we should deifnitely not compare images with different size semantics.
I.e. chunk images which are already local. This is useful e.g. for Fedora images manually downloaded from pungi composes (because Fedora doesn't keep historical tags in its repos).
I found this useful when using the manifest output for doing various analyses and testing tweaks to the algorithm in a more lightweight way.
Use the new -t/--tag switch added in dc805a6 to embed the target image name directly in the OCI archive. This lets podman load tag the image automatically, removing the need to parse the image ID from podman load output and manually call podman tag. Assisted-by: OpenCode (Claude Opus 4.6)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for the containers-storage transport across the image processing toolset, enabling operations on local images. Key updates include the addition of a stability field to the manifest component in src/cmd_build.rs, and logic in analyze-layer-reuse.py to backfill uncompressed layer sizes using podman history for more accurate reporting. The chunk-image-series.py script was also refactored to handle local image tagging and listing via podman. Feedback was provided regarding the robustness of the layer size extraction logic in analyze-layer-reuse.py to prevent potential TypeError exceptions when encountering null values in JSON output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bunch of tweaks I did as part of doing various algo tests and tweaks for #97.