Conversation
One thing sorely missing right now is any feedback of what chunkah is doing. This remedies the situation quite a bit by hooking up the tracing crate and adding logging throughout the codebase. I might've went overboard with the trace level, though it's really nice to be able to follow exactly the data flow for any given path, from scanning, claiming, packing, merging, and serializing to tar. Change all our e2e tests to use the debug level. Assisted-by: Claude Opus 4.5 Closes: #17
Add a convenience target that wraps the Containerfile.splitter workflow from the README. It takes an image and optional chunkah arguments. Assisted-by: Claude Opus 4.5
We need a real filesystem to apply security labels because overlayfs prevents that unprivileged. As mentioned in the comment, we probably should rewrite that whole script to !bash to do the pretty diff we're looking for by inspecting the objects using ostree-native APIs. Anyway, this works for now.
Very often when I ask the agent to change a recipe, it always looks for `justfile` first. This should help. Assisted-by: Claude Opus 4.5
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully integrates the tracing crate for comprehensive logging across the codebase. It introduces a global verbosity flag, configures a tracing-subscriber with a clean output format, and adds detailed log messages at various levels (info, debug, trace, warn). The documentation has been updated with logging guidelines, and end-to-end tests now leverage the verbose output. The changes also include minor improvements to the Justfile and the differ tool, such as an environment check for ostree compatibility. Overall, the implementation is solid and follows the project's established patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing sorely missing right now is any feedback of what chunkah is doing.
This remedies the situation quite a bit by hooking up the tracing crate and adding logging throughout the codebase. I might've went overboard with the trace level, though it's really nice to be able to follow exactly the data flow for any given path, from scanning, claiming,
packing, merging, and serializing to tar.
Change all our e2e tests to use the debug level.
Assisted-by: Claude Opus 4.5
Closes: #17