Skip to content

tree: add size information when logging#70

Merged
jlebon merged 2 commits intomainfrom
size-logging
Feb 26, 2026
Merged

tree: add size information when logging#70
jlebon merged 2 commits intomainfrom
size-logging

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Feb 26, 2026

It's informative to see how large an image is, and the repartition of
the data across the different repos. This could also help catch issues
early on when the expected repartition doesn't match what one would
expect.

Assisted-by: Claude Opus 4.6

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds size information to the logs, which is very helpful for understanding the composition of the built image. The changes are well-implemented and include relevant tests. I have two suggestions for improving maintainability and robustness:

  1. In src/components/mod.rs, I suggest using a dedicated struct for repository statistics instead of a tuple to improve code clarity.
  2. In src/utils.rs, I recommend using an external crate like humansize for formatting file sizes, which is a more robust and standard approach than a custom implementation.

Comment thread src/components/mod.rs Outdated
Comment thread src/utils.rs
It's informative to see how large an image is, and the repartition of
the data across the different repos. This could also help catch issues
early on when the expected repartition doesn't match what one would
expect.

Assisted-by: Claude Opus 4.6
@jlebon jlebon enabled auto-merge (rebase) February 26, 2026 21:31
@jlebon jlebon merged commit 557c974 into main Feb 26, 2026
6 checks passed
@jlebon jlebon deleted the size-logging branch February 26, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant