Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback for SOURCE_DATE_EPOCH to use the Created timestamp from an existing image's metadata, which is a great enhancement for build reproducibility. The implementation is well-executed, including necessary adjustments to configuration parsing and the addition of relevant tests. I have a few suggestions to enhance code clarity, improve test coverage, and align with idiomatic Rust practices.
When splitting an existing image and no SOURCE_DATE_EPOCH is provided, use the Created timestamp from the image inspect output instead of the current time. This makes re-splitting an existing image reproducible without requiring the caller to explicitly set SOURCE_DATE_EPOCH. Assisted-by: Claude Opus 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When splitting an existing image and no SOURCE_DATE_EPOCH is provided, use the Created timestamp from the image inspect output instead of the current time. This makes re-splitting an existing image reproducible without requiring the caller to explicitly set SOURCE_DATE_EPOCH.
Assisted-by: Claude Opus 4.6