README: document support for rechunking OSTree-based bootc images#76
Merged
README: document support for rechunking OSTree-based bootc images#76
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to document support for rechunking OSTree-based bootc images and introduces the CHUNKAH_CONFIG_STR build argument. The documentation is a welcome addition. My review includes a critical fix for a syntax error in a new Dockerfile example, which would prevent it from working correctly. I've also suggested a minor change to improve the clarity of another code snippet.
Note: Security Review has been skipped due to the limited scope of the PR.
I was hesitant to document this because there's various subtle gotchas, but people are doing it anyway, so we might as well provide guidance and document those gotchas. This also documents a `CHUNKAH_CONFIG_STR` build arg one could add in the buildah flow to persist base image metadata without having to repeat it. Assisted-by: Claude Opus 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was hesitant to document this because there's various subtle gotchas, but people are doing it anyway, so we might as well provide guidance and document those gotchas.
This also documents a
CHUNKAH_CONFIG_STRbuild arg one could add in the buildah flow to persist base image metadata without having to repeat it.Assisted-by: Claude Opus 4.6