Conversation
This brings in `Clone` support for `Package`, which we need.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a non-determinism issue in stability calculation by ensuring the minimum stability is used across all sub-packages of a source RPM. The included test effectively validates this fix. I have identified a couple of areas for improvement: the new warning logic introduces its own non-deterministic behavior, and there's an opportunity to reduce code duplication. Please see my detailed comments below.
p5
reviewed
Mar 9, 2026
If a rootfs has packages built from different versions of the same SRPM, (e.g. `foo-1.0-1` and `foo-libs-1.0-2`), current chunkah logic is to still put them in the same component. This seems like the right call because clearly the package set hasn't converged yet and more churn is expected. If that does happen, we should make sure to have a deterministic stability. Right now it just depends on whichever subpackage is encountered first, which may change between invocations. Always calculate stability, and use the lower of the two. While we're there, warn if we encounter this since it likely indicates a compose bug on the user's side. Closes: #80 Assisted-by: OpenCode (Claude Opus 4.6)
Member
Author
|
Just going to force-merge this. CI has already passed on it and the only change is a comment string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a rootfs has packages built from different versions of the same SRPM, (e.g.
foo-1.0-1andfoo-libs-1.0-2), current chunkah logic is to still put them in the same component. This seems like the right call because clearly the package set hasn't converged yet and more churn is expected.If that does happen, we should make sure to have a deterministic stability. Right now it just depends on whichever subpackage is encountered first, which may change between invocations.
Always calculate stability, and use the lower of the two. While we're there, warn if we encounter this since it likely indicates a compose bug on the user's side.
Closes: #80
Assisted-by: OpenCode (Claude Opus 4.6)