Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new bump command to the release.py script to automate version bumping across the project. The changes update the version to v0.3.1 in Cargo.toml, Cargo.lock, README.md, and packaging/chunkah.spec. The versioncheck in Justfile is also updated to verify the version in the spec file. The release script now also automatically updates the License field in the spec file based on the project's dependencies. The overall implementation is a great improvement for release management. I have one suggestion regarding the git branch creation logic in release.py to make it safer.
Add a 'bump' subcommand to release.py that updates the version across Cargo.toml, Cargo.lock, packaging/chunkah.spec, and README.md in one step, replacing the error-prone manual editing of 4 files. The existing release-cutting logic moves to the 'cut' subcommand. Also extend versioncheck to validate packaging/chunkah.spec against Cargo.toml, closing the gap where spec file mismatches were not caught. Closes: #57 Assisted-by: OpenCode (Claude Opus 4.6)
Compute the License tag by running cargo tree to collect all dependency licenses, normalizing SPDX expressions, and ANDing them together. This follows the Fedora convention used by other Rust packages where the License tag must include all vendored dependency licenses. See also https://bugzilla.redhat.com/show_bug.cgi?id=2435617#c8. Assisted-by: OpenCode (Claude Opus 4.6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.