build: Error out when rootfs contains unpruned ostree sysroot#99
Merged
jlebon merged 1 commit intocoreos:mainfrom Apr 1, 2026
Merged
build: Error out when rootfs contains unpruned ostree sysroot#99jlebon merged 1 commit intocoreos:mainfrom
jlebon merged 1 commit intocoreos:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a validation step to ensure that OSTree object stores within a rootfs are explicitly pruned during the build process, preventing suboptimal chunking results. The implementation includes a new check_ostree_sysroot function and corresponding unit tests. Feedback suggests improving the robustness of the prune path check by using path-based prefix matching instead of exact string comparisons to correctly identify when a sub-path covers the target directory.
jlebon
reviewed
Mar 31, 2026
cgwalters
force-pushed
the
error-if-ostree
branch
2 times, most recently
from
4d83e2d to
f181549
Compare
Chunking an ostree object store produces poor results and is almost certainly a user error. Detect this by checking the scanned file map for /sysroot/ostree paths (which naturally respects --prune) and warn with a 7-second sleep so the message is visible in scrolling output. This is a soft warning rather than a hard error since chunkah should not strictly enforce this -- no data loss is involved, just suboptimal layer splitting. Refs: coreos#97 Assisted-by: OpenCode (Claude Opus 4)
jlebon
approved these changes
Apr 1, 2026
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Thanks! (Force-pushed to drop some duplicate comments.)
Member
Author
Thanks and sorry I missed that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunking an ostree object store produces poor results and is almost certainly a user error (the objects directory contains many small content-addressed files that defeat component-based grouping). Detect this early and point the user to the README section on bootc compatibility.
The check passes if --prune /sysroot/ is specified, which is the documented approach for rechunking bootc images.
Refs: #97
Assisted-by: OpenCode (Claude Opus 4)