-
Notifications
You must be signed in to change notification settings - Fork 183
src/create_disk.sh: change bls-append-except-default seperator #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We have decided to change the seperator used in the bls-append-except-default-key. We want to add to the changes in coreos#2854.
|
Let's wait for ostreedev/ostree#2605 to merge before merging this. I will not hit auto-merge this time 😅 |
NVM CI on ostreedev/ostree#2605 needs this change to pass - lets merge this. |
dustymabe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: I haven't followed the minutia of these changes.
Trivial LGTM
|
@saqibali-2k It is already merged, but could you explain why we decided to change it? Is it just a detail or there is some reason? |
|
We are adding a corresponding change in OSTree that uses the string-list |
This PR is followup from coreos/coreos-assembler#2863 Summary of changes: - Moved bls-append-except-default parsing logic to reload_sysroot_config() - Made sure heap allocated memory is being freed
This PR is followup from coreos/coreos-assembler#2863 Summary of changes: - Moved bls-append-except-default parsing logic to reload_sysroot_config() - Made sure heap allocated memory is being freed
This PR is followup from coreos/coreos-assembler#2863 Summary of changes: - Moved bls-append-except-default parsing logic to reload_sysroot_config() - Made sure heap allocated memory is being freed
This PR is followup from coreos/coreos-assembler#2863 Summary of changes: - Moved bls-append-except-default parsing logic to reload_sysroot_config() - Made sure heap allocated memory is being freed
This PR is followup from coreos/coreos-assembler#2863 Summary of changes: - Moved bls-append-except-default parsing logic to reload_sysroot_config() - Made sure heap allocated memory is being freed
We have decided to change the seperator used in the
bls-append-except-default-key. We want to add to the changes
in #2854.