Skip to content

Conversation

@saqibali-2k
Copy link
Member

We have decided to change the seperator used in the
bls-append-except-default-key. We want to add to the changes
in #2854.

We have decided to change the seperator used in the
bls-append-except-default-key. We want to add to the changes
in coreos#2854.
@saqibali-2k
Copy link
Member Author

Let's wait for ostreedev/ostree#2605 to merge before merging this. I will not hit auto-merge this time 😅

@saqibali-2k
Copy link
Member Author

saqibali-2k commented May 19, 2022

Let's wait for ostreedev/ostree#2605 to merge before merging this. I will not hit auto-merge this time

NVM CI on ostreedev/ostree#2605 needs this change to pass - lets merge this.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I haven't followed the minutia of these changes.

Trivial LGTM

@saqibali-2k saqibali-2k merged commit 9e76271 into coreos:main May 19, 2022
@ravanelli
Copy link
Member

@saqibali-2k It is already merged, but could you explain why we decided to change it? Is it just a detail or there is some reason?

@saqibali-2k
Copy link
Member Author

We are adding a corresponding change in OSTree that uses the string-list bls-append-except-default specified here. Originally, the format of the key was key1,value1;key2,value2; however, we found it was more clear to do something like key1=value1;key2=value2. We added the change in the OSTree PR linked above, but tests are failing since the bls-append-except-default key set by COSA is incorrect format.

saqibali-2k added a commit to saqibali-2k/ostree that referenced this pull request Jul 5, 2022
This PR is followup from coreos/coreos-assembler#2863
Summary of changes:
- Moved bls-append-except-default parsing logic to reload_sysroot_config()
- Made sure heap allocated memory is being freed
saqibali-2k added a commit to saqibali-2k/ostree that referenced this pull request Jul 6, 2022
This PR is followup from coreos/coreos-assembler#2863
Summary of changes:
- Moved bls-append-except-default parsing logic to reload_sysroot_config()
- Made sure heap allocated memory is being freed
saqibali-2k added a commit to saqibali-2k/ostree that referenced this pull request Jul 6, 2022
This PR is followup from coreos/coreos-assembler#2863
Summary of changes:
- Moved bls-append-except-default parsing logic to reload_sysroot_config()
- Made sure heap allocated memory is being freed
saqibali-2k added a commit to saqibali-2k/ostree that referenced this pull request Jul 7, 2022
This PR is followup from coreos/coreos-assembler#2863
Summary of changes:
- Moved bls-append-except-default parsing logic to reload_sysroot_config()
- Made sure heap allocated memory is being freed
saqibali-2k added a commit to saqibali-2k/ostree that referenced this pull request Jul 7, 2022
This PR is followup from coreos/coreos-assembler#2863
Summary of changes:
- Moved bls-append-except-default parsing logic to reload_sysroot_config()
- Made sure heap allocated memory is being freed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants