cmd-buildextend-live: always change EFI/{vendor} to correct vendor id#3048
Merged
cgwalters merged 1 commit intocoreos:mainfrom Aug 31, 2022
Merged
cmd-buildextend-live: always change EFI/{vendor} to correct vendor id#3048cgwalters merged 1 commit intocoreos:mainfrom
EFI/{vendor} to correct vendor id#3048cgwalters merged 1 commit intocoreos:mainfrom
Conversation
bgilbert
reviewed
Aug 26, 2022
HuijingHei
force-pushed
the
efi-distro
branch
2 times, most recently
from
1fc0a06 to
1132bd9
Compare
Contributor
Author
|
Build c9s live iso locally, run uefi-secure test, result is passed. |
cgwalters
previously approved these changes
Aug 30, 2022
Member
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Nice work! To be clear: I'm good to merge this as is to unblock C9S work, we can do my suggested tweaks as a followup too.
cgwalters
previously approved these changes
Aug 30, 2022
bgilbert
reviewed
Aug 30, 2022
Contributor
bgilbert
left a comment
bgilbert
left a comment
There was a problem hiding this comment.
Thanks for handling this!
HuijingHei
force-pushed
the
efi-distro
branch
2 times, most recently
from
3adc7af to
c103d5e
Compare
HuijingHei
changed the title
EFI/{distro}/grub.cfg to EFI/centos/grub.cfg for scosEFI/{vendor} to correct vendor id
HuijingHei
added a commit
to HuijingHei/os
that referenced
this pull request
Sep 2, 2022
Consider of building scos using centos stream, we want to make this more flexiable to different ventor instead of fixed `redhat`. Change with coreos-assember refer to coreos/coreos-assembler#3048
travier
pushed a commit
to travier/os
that referenced
this pull request
Sep 5, 2022
Consider of building scos using centos stream, we want to make this more flexiable to different ventor instead of fixed `redhat`. Change with coreos-assember refer to coreos/coreos-assembler#3048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix openshift/os#954