[rhcos-4.13] mantle/platform: allow systemctl is-system-running nonzero exit codes#3497
Conversation
The `CheckMachine()` call tolerates `systemctl is-system-running` returning e.g. `starting` and `initializing` in addition to the usual `running`. But by design, the command returns a nonzero exit code in those cases. Since we're explicitly checking the output string against the acceptable states, just ignore the command exit code so that we don't fail if the system is still starting. Prep for adding a test in which we expect the system to still be `starting`.
|
Hi @openshift-cherrypick-robot. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
LGTM |
|
/retest |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
the CI failure here is merging over red so we can unblock that other PR too. |
4 participants
This is an automated cherry-pick of #3487
/assign travier