cmdlib.py: minor tweaks related to OCI imports#4227
Merged
Conversation
Merged
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Address some comments from coreos#4164.
jlebon
force-pushed
the
pr/import-followups
branch
from
f5d28ce to
4563969
Compare
jbtrystram
previously approved these changes
Jul 18, 2025
We had this really subtle interaction going on between cosa build and prune, where we were actually relying on the prune code to regenerate `builds.json` to add the new build we just did. There's history there on how we got here, but at this point it just feels weird. It's cleaner to always insert the new build ourselves and then separately call `cosa prune` so let's do that.
Member
Author
|
OK wow, the new code in #4164 unearthed funky semantics in cmd-build. Added another commit to fix that which should fix CI. |
Member
|
I'm not even able to get to prow so I'm skipping CI on ci/prow/rhcos to get this fix in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address some comments from #4164.