butane: replace LAYOUT with architecture before render#4525
Merged
dustymabe merged 1 commit intocoreos:mainfrom Apr 9, 2026
Merged
butane: replace LAYOUT with architecture before render#4525dustymabe merged 1 commit intocoreos:mainfrom
LAYOUT with architecture before render#4525dustymabe merged 1 commit intocoreos:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces architecture-based substitution for Butane configurations in kola qemuexec and test registration, defaulting to the current RPM architecture when none is provided. Feedback suggests refactoring the manual string replacement logic to use the existing Subst method for better consistency and readability. It is also recommended to use a more unique placeholder than 'LAYOUT' to avoid unintended replacements in configuration files.
HuijingHei
added a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Apr 8, 2026
The test failed on aarch64 / ppc64le because of missing `layout`. Requires coreos/coreos-assembler#4525
HuijingHei
force-pushed
the
butane-config
branch
2 times, most recently
from
cdc1e29 to
da72067
Compare
HuijingHei
force-pushed
the
butane-config
branch
from
da72067 to
7d85534
Compare
HuijingHei
added a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Apr 8, 2026
The test failed on aarch64 / ppc64le because of missing `layout`. Requires coreos/coreos-assembler#4525
Contributor
Author
|
Test passed on x86_64 and aarch64 with coreos/fedora-coreos-config#4097 |
HuijingHei
added a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Apr 8, 2026
The test failed on aarch64 / ppc64le because of missing `layout`. Requires coreos/coreos-assembler#4525
Rolv-Apneseth
previously approved these changes
Apr 8, 2026
Member
Rolv-Apneseth
left a comment
Rolv-Apneseth
left a comment
There was a problem hiding this comment.
LGTM. Not entirely familiar with the kola code base but changes look reasonable and the modified test works.
dustymabe
reviewed
Apr 8, 2026
HuijingHei
force-pushed
the
butane-config
branch
from
7d85534 to
8c14065
Compare
HuijingHei
added a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Apr 9, 2026
Fix test failed on aarch64 / ppc64le because of missing `layout`. Requires coreos/coreos-assembler#4525
dustymabe
reviewed
Apr 9, 2026
Fix failed test on aarch64 / ppc64le, the `.Subst("{{LAYOUT}}")`
is required for `raid1-boot` test, see coreos/fedora-coreos-config#4097
auto-merge was automatically disabled
April 9, 2026 02:28
Head branch was pushed to by a user without write access
HuijingHei
force-pushed
the
butane-config
branch
from
8c14065 to
77fda17
Compare
Member
|
not sure what is up with prow /retest |
dustymabe
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Apr 9, 2026
Fix test failed on aarch64 / ppc64le because of missing `layout`. Requires coreos/coreos-assembler#4525
Rolv-Apneseth
pushed a commit
to Rolv-Apneseth/fedora-coreos-config
that referenced
this pull request
Apr 16, 2026
Fix test failed on aarch64 / ppc64le because of missing `layout`. Requires coreos/coreos-assembler#4525
HuijingHei
added a commit
to HuijingHei/bootupd
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failed test on aarch64 / ppc64le.