This repository was archived by the owner on Feb 12, 2021. It is now read-only.
os: add section on visudo usage to adding-users doc#898
Merged
joshix merged 2 commits intocoreos:masterfrom Oct 22, 2016
Merged
os: add section on visudo usage to adding-users doc#898joshix merged 2 commits intocoreos:masterfrom
joshix merged 2 commits intocoreos:masterfrom
Conversation
Visudo on CoreOS requires the file be specified or an error is thrown. Issue: coreos/bugs#1617
joshix
approved these changes
Oct 18, 2016
Contributor
joshix
left a comment
joshix
left a comment
There was a problem hiding this comment.
Only 2 nits about formatting so it's clear the command name and file name is literal. LGTM with or without the changes.
os/adding-users.md
Outdated
|
|
||
| ## Grant sudo Access | ||
|
|
||
| If you trust the user you can grant administrative privileges using visudo. visudo checks the file syntax before actually overwriting the sudoers file. This command should be ran as root to avoid losing sudo access in the event of a failure. Instead of editing /etc/sudo.conf directly you will create a new file under the `/etc/sudoers.d/` directory. When you run visudo it is required that you specify which file you are attempting to edit with the -f argument: |
Contributor
There was a problem hiding this comment.
backticks: visudo.
backticks: sudoers
crawford
suggested changes
Oct 18, 2016
os/adding-users.md
Outdated
|
|
||
| ## Grant sudo Access | ||
|
|
||
| If you trust the user you can grant administrative privileges using visudo. visudo checks the file syntax before actually overwriting the sudoers file. This command should be ran as root to avoid losing sudo access in the event of a failure. Instead of editing /etc/sudo.conf directly you will create a new file under the `/etc/sudoers.d/` directory. When you run visudo it is required that you specify which file you are attempting to edit with the -f argument: |
Contributor
There was a problem hiding this comment.
"If you trust the user, you..."
os/adding-users.md
Outdated
|
|
||
| ## Grant sudo Access | ||
|
|
||
| If you trust the user you can grant administrative privileges using visudo. visudo checks the file syntax before actually overwriting the sudoers file. This command should be ran as root to avoid losing sudo access in the event of a failure. Instead of editing /etc/sudo.conf directly you will create a new file under the `/etc/sudoers.d/` directory. When you run visudo it is required that you specify which file you are attempting to edit with the -f argument: |
Contributor
There was a problem hiding this comment.
"This command should be run as root..."
os/adding-users.md
Outdated
|
|
||
| ## Grant sudo Access | ||
|
|
||
| If you trust the user you can grant administrative privileges using visudo. visudo checks the file syntax before actually overwriting the sudoers file. This command should be ran as root to avoid losing sudo access in the event of a failure. Instead of editing /etc/sudo.conf directly you will create a new file under the `/etc/sudoers.d/` directory. When you run visudo it is required that you specify which file you are attempting to edit with the -f argument: |
Contributor
There was a problem hiding this comment.
"When you run visudo, it..."
… by crawford/josh
crawford
approved these changes
Oct 18, 2016
Contributor
|
Can you please rebase before merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visudo on CoreOS requires the file be specified or an error is thrown.
Issue: coreos/bugs#1617