This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Finish SSH Username Support#1092
Merged
Merged
Conversation
Implements --ssh-username to allow fleetctl users to specify arbitrary usernames on upstream servers. Fixes coreos#536
Implements --ssh-username for `fleetctl ssh` to allow users to connect as arbitrary remote users. fixes coreos#536
journalctl needs to have access to the actual journal files and custom users aren't part of the `systemd-journal` group. This is a somewhat hacky way to allow custom users to escalate their priviledges to view the journal.
Contributor
There was a problem hiding this comment.
Let's not add the shortened version of the flag until we have a library to help make it less cumbersome.
Contributor
|
LGTM after you remove the |
Contributor
Author
|
Done |
Contributor
|
awesome, lgtm, thanks for finishing this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed this functionality and noticed everything seemed pretty close. My last commit here makes all commands work correctly for me.
There is one caveat that I documented in using-the-client. The
journalcommand executesjournalctlwhich needs permission to view the journald files. I added a--sudoflag to the journal command as a solution but I can't say I'm extremely happy with it but it should work by default since the sudo group is passwordless.Linking:
Updates #1076 to fix comment from #904 and should finally close #536