fleetd: try ports 2379 and 4001 by default for etcd#1177
Conversation
There was a problem hiding this comment.
would rather just define defaultEndpoints as a []string
|
LGTM, with the (discussed) caveat that it will result in suboptimal performance in scenarios where it isn't listening on both ports. Probably get an ack from @bcwaldon |
|
Could we switch the ordering to prefer 4001 for the time-being? I believe the client is so dumb it will always start at the beginning of the list of endpoints for every request, ignoring the last known healthy node. |
|
Done. |
|
@crawford Please update |
|
@bcwaldon updated. |
There was a problem hiding this comment.
The order of the default here is backwards.
There was a problem hiding this comment.
This is the order that fleetctl uses. (yes, it's opposite of the daemon)
|
@crawford so close, crawfish. LGTM after my two comments are addressed |
|
LGTM |
fleetd: try ports 2379 and 4001 by default for etcd
3 participants
Fixes #1171.