fleetctl: properly run local and remote commands

[crawford]

Remote commands need to be escaped because they are being interpretted
by a shell. Local commands, however, cannot be because they are being
exec'd. Additionally, splitting an opaque command by space is very error
prone (e.g. ls "dumb filename").

[crawford]

Still testing...

[crawford]

Locally running service:

$ ./fleetctl status redis.service
● redis.service
   Loaded: loaded (/run/fleet/units/redis.service; linked-runtime; vendor preset: disabled)
   Active: active (running) since Wed 2015-06-17 20:59:18 ; 2h 13min ago
 Main PID: 651 (sleep)
   Memory: 120.0K
   CGroup: /system.slice/redis.service
           └─651 /usr/bin/sleep 1000000

Jun 17 20:59:18 crawford-test-2 systemd[1]: Started redis.service.
Jun 17 20:59:18 crawford-test-2 systemd[1]: Starting redis.service...

Remotely running service:

$ ./fleetctl status redis.service
● redis.service
   Loaded: loaded (/run/fleet/units/redis.service; linked-runtime; vendor preset: disabled)
   Active: active (running) since Wed 2015-06-17 20:59:18 ; 2h 14min ago
 Main PID: 651 (sleep)
   Memory: 120.0K
   CGroup: /system.slice/redis.service
           └─651 /usr/bin/sleep 1000000

Jun 17 20:59:18 crawford-test-2 systemd[1]: Started redis.service.
Jun 17 20:59:18 crawford-test-2 systemd[1]: Starting redis.service...

$ ./fleetctl journal redis.service
-- Logs begin at Wed 2015-06-17 20:56:43 , end at Wed 2015-06-17 23:16:03 . --
Jun 17 20:59:18 crawford-test-2 systemd[1]: Started redis.service.
Jun 17 20:59:18 crawford-test-2 systemd[1]: Starting redis.service...

$ ./fleetctl journal --sudo redis.service       
-- Logs begin at Wed 2015-06-17 20:56:43 , end at Wed 2015-06-17 23:16:15 . --
Jun 17 20:59:18 crawford-test-2 systemd[1]: Started redis.service.
Jun 17 20:59:18 crawford-test-2 systemd[1]: Starting redis.service...

$ ./fleetctl journal --sudo --follow redis.service
-- Logs begin at Wed 2015-06-17 20:56:43 . --
Jun 17 20:59:18 crawford-test-2 systemd[1]: Started redis.service.
Jun 17 20:59:18 crawford-test-2 systemd[1]: Starting redis.service...^C

[crawford]

govet is failing to compile. Fantastic.

[jonboulle]

The approach lgtm

[crawford]

$ go version
go version go1.4 linux/amd64

$ ./test                           
Building fleetd...
Building fleetctl...
Running tests...
ok      github.com/coreos/fleet/agent   0.010s  coverage: 70.6% of statements
ok      github.com/coreos/fleet/api 0.008s  coverage: 80.4% of statements
ok      github.com/coreos/fleet/config  0.003s  coverage: 100.0% of statements
ok      github.com/coreos/fleet/engine  0.009s  coverage: 54.5% of statements
ok      github.com/coreos/fleet/fleetctl    0.012s  coverage: 23.2% of statements
ok      github.com/coreos/fleet/job 0.007s  coverage: 89.2% of statements
ok      github.com/coreos/fleet/machine 0.004s  coverage: 35.1% of statements
ok      github.com/coreos/fleet/pkg 0.023s  coverage: 81.9% of statements
ok      github.com/coreos/fleet/pkg/lease   0.004s  coverage: 14.3% of statements
ok      github.com/coreos/fleet/registry    0.004s  coverage: 26.7% of statements
ok      github.com/coreos/fleet/ssh 0.005s  coverage: 42.5% of statements
ok      github.com/coreos/fleet/systemd 0.003s  coverage: 15.5% of statements
ok      github.com/coreos/fleet/unit    0.003s  coverage: 88.4% of statements
Checking gofmt...
Checking govet...
Success

[bcwaldon]

@crawford LGTM, stupid travis

[oxtopus]

Thanks!