This repository was archived by the owner on Sep 22, 2020. It is now read-only.
Regenerate response code with codecgen v4#243
Merged
jonboulle merged 1 commit intocoreos:masterfrom Sep 18, 2015
bbickerton:codecgen_v3_to_v4
Merged
Regenerate response code with codecgen v4#243jonboulle merged 1 commit intocoreos:masterfrom bbickerton:codecgen_v3_to_v4
jonboulle merged 1 commit intocoreos:masterfrom
bbickerton:codecgen_v3_to_v4
Conversation
Contributor
|
This is annoying :/. Thanks once again. |
jonboulle
added a commit
that referenced
this pull request
Sep 18, 2015
Regenerate response code with codecgen v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the response code was regenerated with codecgen v3 ugorji/go@718a1bc in PR #239 , there was another update, to codecgen v4 ugorji/go@1d5269e. This broke the generated code again (Issue https://github.com/coreos/go-etcd/issues/242).
Regenerated code with the latest codecgen. No longer seeing the errors posted in the issue, tests are passing on my machine.