Drop another allocation in the loop#19
Merged
cgwalters merged 1 commit intocoreos:mainfrom Feb 3, 2023
Merged
Conversation
cgwalters
force-pushed
the
drop-another-allocation
branch
from
bc01789 to
62dee84
Compare
cgwalters
force-pushed
the
drop-another-allocation
branch
from
62dee84 to
1180b94
Compare
Member
Author
|
Rebased 🏄 |
There's no reason to create an owned `PathBuf` for comparison.
cgwalters
force-pushed
the
drop-another-allocation
branch
from
1180b94 to
df4f71a
Compare
nabijaczleweli
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason to create an owned
PathBuffor comparison.