Replace FragmentScanner with scan(), and turn around the bool#20
Merged
cgwalters merged 1 commit intocoreos:mainfrom Feb 3, 2023
Merged
Replace FragmentScanner with scan(), and turn around the bool#20cgwalters merged 1 commit intocoreos:mainfrom
cgwalters merged 1 commit intocoreos:mainfrom
Conversation
9f408fe to
fa0700e
Compare
Member
|
OK yeah, I'm good with this. I think I'd probably still like a builder-style API potentially but it can be based on top of this later. However, let's do a semver-compatible release first with the current fixes if that's OK with you? |
Collaborator
Author
|
Sure, whatever. |
26408a2 to
8b0b62f
Compare
Take base_dirs: IntoIter<AsRef<Path>>,
shared_path: AsRef<Path>,
allowed_extensions: &[AsRef<OsStr>]
This makes client code a hell of a lot more flexible,
and the arguments make more semantic sense
Closes: coreos#12
8b0b62f to
219610c
Compare
Collaborator
Author
|
This is g2g then I think |
cgwalters
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take base_dirs: IntoIter<AsRef>, shared_path: AsRef, allowed_extensions: &[AsRef]
This makes client code a hell of a lot more flexible, and the arguments make more semantic sense; in particular, it means you can do
and it Just Works