fix: remove unsafe exec() in g_spawn.c#44
Merged
corepunch merged 1 commit intoMay 9, 2026
Merged
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
game/g_spawn.c.Vulnerability
V-001game/g_spawn.c:92Description: Five calls to sprintf() in the entity spawn function write formatted path strings into a fixed-size stack buffer without any bounds checking. The format strings incorporate attacker-influenced values: edict->variation (an integer from map data), edict->class_id (used via the DESTRUCTABLE_TEXTURE macro), and the path strings dir and file. If any of these values are supplied via a crafted map file or network packet, the resulting string can exceed the buffer size, overflowing the stack and overwriting the saved return address, enabling arbitrary code execution.
Changes
game/g_spawn.cVerification
Automated security fix by OrbisAI Security