ci: fix for Workflow does not contain permissions#116
Merged
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/coreruleset/secrules_parsing/security/code-scanning/2
In general, the fix is to add an explicit
permissionsblock to the workflow (either at the top level or per job) and set it to the minimal access required. For a regression test workflow that only checks out code and runs tests, read-only repository contents are sufficient in most cases, socontents: readis an appropriate baseline.The single best fix here is to define workflow-wide permissions just under the
nameandonkeys, so they apply to all jobs that don’t override them. The existing steps (actions/checkout,actions/setup-python,abatilo/actions-poetry, and running tests/commands) all function correctly with only read access to repository contents and default read access to other scopes. No changes to the job steps are necessary. Concretely, in.github/workflows/test.yml, insert:between the
on: [push, pull_request]line and thejobs:line. No imports or other definitions are needed as this is purely a YAML configuration change.Suggested fixes powered by Copilot Autofix. Review carefully before merging.