Conversation
…ne inputs without whitespace. Fix #3.
…SPARQL queries with URIs
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug where inline SPARQL queries containing URIs were mistakenly classified as file paths. Key changes include:
- Adding tests to verify that single-line inline SPARQL queries with URIs are correctly detected.
- Introducing a test for file paths with spaces.
- Updating the heuristic in InputTypeDetector to distinguish between SPARQL queries and file paths.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/java/fr/inria/corese/command/utils/InputTypeDetectorTest.java | Added tests for inline SPARQL and file paths with spaces |
| src/main/java/fr/inria/corese/command/utils/InputTypeDetector.java | Modified criteria for differentiating SPARQL queries from file paths |
| CHANGELOG.md | Updated changelog with bug fix details |
Comments suppressed due to low confidence (1)
src/main/java/fr/inria/corese/command/utils/InputTypeDetector.java:98
- The current condition excludes file paths with whitespace from being classified as such, contradicting the added test for 'detectFilePathWithSpaces'. Consider modifying the condition to correctly detect file paths even when they contain whitespace.
if (isSingleLine && !hasWhitespace && looksLikePath) {
|
remiceres
deleted the
3-bug-query-remote-interprets-inline-sparql-queries-as-file-paths
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.