string literals#113
Merged
MaillPierre merged 9 commits intoApr 14, 2025
Merged
Conversation
- CoreseTyped - CoreseLanguageTaggedString
Contributor
|
I made a commit to reorganize the classes according to the recent coding convention we set up since the first pull request. Overall, I see no problem in the code. I would like you to make a pass to add comments over any class and functions that you have made. For functions, my policy is that if it overrides another one and behaves as the super class described, it doesn't need a repeat of the docstring. Additionally, maybe rename |
MaillPierre
added
the
Refactoring
…al_classes_102 # Conflicts: # src/main/java/fr/inria/corese/core/next/impl/temp/CoreseAdaptedValueFactory.java # src/main/java/fr/inria/corese/core/next/impl/temp/literal/CoreseBoolean.java # src/test/java/fr/inria/corese/core/next/api/model/impl/corese/CoreseAdaptedValueFactoryTest.java # src/test/java/fr/inria/corese/core/next/impl/common/literal/CoreseBooleanTest.java
MaillPierre
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalizedAbstractString to create string literal with language tag and AbstractString to create string literal with xsd:string.