Feature/212 canonical rdf #220

abdessamad-abdoun · 2025-11-03T13:17:30Z

No description provided.

github-actions · 2025-11-03T13:36:11Z

Test Results

957 tests ±0 957 ✅ ±0 35s ⏱️ -1s
71 suites ±0 0 💤 ±0
71 files ±0 0 ❌ ±0

Results for commit 174e581. ± Comparison against base commit ee566fc.

♻️ This comment has been updated with latest results.

MaillPierre · 2025-11-03T14:06:20Z

src/main/java/fr/inria/corese/core/next/api/base/model/AbstractIRI.java

Why remove the standard format checking here ?

Maybe incorporate all your work into validateIRI into / replacing isStandardIRI ?

MaillPierre · 2025-11-03T14:08:08Z

src/main/java/fr/inria/corese/core/next/impl/io/parser/common/AbstractTurtleTriGListener.java

-                throw new ParsingErrorException("Undeclared prefix: " + prefix);
            }

-            return resolveIRIAgainstBase(raw);


Minor: Put back the return in inline form here

MaillPierre · 2025-11-03T14:09:11Z

src/main/java/fr/inria/corese/core/next/impl/io/parser/common/AbstractTurtleTriGListener.java

    public String extractAndUnescapeIRI(String text) {
        String iri = text.substring(1, text.length() - 1);
-        return unescapeIRI(iri);
+        iri = unescapeIRI(iri);


Document the fact that validateIRI will make this function throw an exception

MaillPierre · 2025-11-03T14:11:37Z

src/main/java/fr/inria/corese/core/next/impl/io/parser/common/AbstractTurtleTriGListener.java

+     * @param c the character to validate
+     * @return true if the character is forbidden in IRIs
+     */
+    private boolean isInvalidIRICharacter(char c) {


Should be put in the IRIUtils class

MaillPierre · 2025-11-03T14:12:20Z

src/main/java/fr/inria/corese/core/next/impl/io/parser/common/AbstractTurtleTriGListener.java

+     * @param iri the IRI string to validate (after escape sequences have been processed)
+     * @throws ParsingErrorException if the IRI contains forbidden characters
+     */
+    private void validateIRI(String iri) throws ParsingErrorException {


Make a boolean returning version or make it replace isStandardURI ?

MaillPierre · 2025-11-03T14:14:12Z

src/test/java/fr/inria/corese/core/next/api/model/ValueFactoryTest.java


        assertNotNull(this.valueFactory.createIRI(correctIRI));
-        assertThrows(IncorrectFormatException.class, () -> this.valueFactory.createIRI(incorrectIRI));
+//        assertThrows(IncorrectFormatException.class, () -> this.valueFactory.createIRI(incorrectIRI));


Delete, do not comment

MaillPierre · 2025-11-03T14:15:09Z

src/test/java/fr/inria/corese/core/next/impl/temp/CoreseIRITest.java

        assertEquals("test", coreseIRI2.getLocalName());
    }

-    @Test


There should still be a test for an incorrect IRI given to the constructor

github-actions · 2025-11-12T09:13:06Z

Overall Project	49.8% `-0.16%`	🍏
Files changed	50.3%	❌

File	Coverage
RDFC10Canonicalizer.java	79.96% `-3.9%`	🍏
IRIUtils.java	60.67% `-31.93%`	❌
TriGParser.java	51.1%	🍏
TurtleParser.java	44.13%	🍏
AbstractTurtleTriGListener.java	41.09% `-4.13%`	❌
StatementUtils.java	40.14% `-50.79%`	❌

github-actions · 2025-11-17T10:48:39Z

Overall Project	49.92% `-0.16%`	🍏
Files changed	50.3%	❌

File	Coverage
RDFC10Canonicalizer.java	79.96% `-3.9%`	🍏
IRIUtils.java	60.67% `-31.93%`	❌
TriGParser.java	51.1%	🍏
TurtleParser.java	44.13%	🍏
AbstractTurtleTriGListener.java	41.09% `-4.13%`	❌
StatementUtils.java	40.14% `-50.79%`	❌

github-actions · 2025-11-18T08:23:20Z

Overall Project	49.92% `-0.16%`	🍏
Files changed	50.3%	❌

File	Coverage
RDFC10Canonicalizer.java	79.96% `-3.9%`	🍏
IRIUtils.java	60.67% `-31.93%`	❌
TriGParser.java	51.1%	🍏
TurtleParser.java	44.13%	🍏
AbstractTurtleTriGListener.java	41.09% `-4.13%`	❌
StatementUtils.java	40.14% `-50.79%`	❌

github-actions · 2025-11-19T10:11:42Z

Overall Project	49.92% `-0.26%`	🍏
Files changed	53.03%	❌

File	Coverage
XSD.java	100%	🍏
RDFSerializer.java	100%	🍏
TriGSerializerOptions.java	100%	🍏
RDF.java	98.9% `-1.1%`	🍏
RDFS.java	96.4% `-1.44%`	🍏
RDFXMLSerializerOption.java	95.47%	🍏
RDFC10SerializerOptions.java	95.45%	🍏
OWL.java	94.85% `-2.06%`	🍏
TurtleSerializerOptions.java	93.85%	🍏
SerializerFactory.java	89.06% `-4.69%`	🍏
RDFXMLUtils.java	84.64% `-2.51%`	❌
AbstractIRI.java	84.55%	🍏
JSONLDSerializer.java	84.38% `-3.13%`	🍏
JSONLDParser.java	82.33% `-2.41%`	🍏
RDFXMLSerializer.java	81.86% `-1.36%`	🍏
JSONLDOptions.java	80.37%	🍏
RDFC10Canonicalizer.java	79.96% `-3.9%`	🍏
RDFC10Serializer.java	79.66%	🍏
AbstractLineBasedSerializer.java	75.08% `-12.04%`	❌
SerializationException.java	74.68%	🍏
NQuadsSerializer.java	71.43%	🍏
NTriplesSerializer.java	68.57%	🍏
TriGSerializer.java	63.54%	🍏
AbstractGraphSerializer.java	61.14% `-6.8%`	❌
IRIUtils.java	60.67% `-31.93%`	❌
TriGListerner.java	56.54%	🍏
TurtleSerializer.java	54.88%	🍏
TitaniumRDFDatasetSerializationAdapter.java	53.62% `-1.28%`	❌
TriGParser.java	51.1%	🍏
IOConstants.java	46.67% `-53.33%`	❌
TurtleParser.java	44.13%	🍏
AbstractTurtleTriGListener.java	41.09% `-4.59%`	❌
StatementUtils.java	39.95% `-51.02%`	❌
FOAF.java	25.93% `-74.07%`	❌
Vocabulary.java	0%	❌
ParserConstants.java	0%	🍏

github-actions · 2025-11-20T10:10:47Z

Overall Project	50.03% `-0.16%`	🍏
Files changed	50.2%	❌

File	Coverage
RDFC10Canonicalizer.java	79.96% `-3.9%`	🍏
IRIUtils.java	60.67% `-31.93%`	❌
TriGParser.java	51.1%	🍏
TurtleParser.java	44.13%	🍏
AbstractTurtleTriGListener.java	41.09% `-4.13%`	❌
StatementUtils.java	39.95% `-51.02%`	❌

remiceres

Looks good to me, thanks for the work! I left a few comments, mostly based on SonarQube findings.

remiceres · 2025-11-21T13:15:14Z

src/main/java/fr/inria/corese/core/next/impl/common/util/IRIUtils.java

            Matcher matcher = matchWithTimeout(IRI_PATTERN, iri);
            if (matcher == null || !matcher.matches()) {
-                return "";
+                return iri.endsWith("#") ? iri : (iri.contains("#") ? iri.substring(0, iri.lastIndexOf("#") + 1) : iri);


Extract this nested ternary operation into an independent statement

remiceres · 2025-11-21T13:17:44Z

src/main/java/fr/inria/corese/core/next/impl/io/serialization/util/StatementUtils.java

+     * @return A canonical N-Quad string with placeholder substitution.
+     */
+    public static String quadToNQuad(Statement quad, String blankNodeToReplace, String replacement) {
+        StringBuilder sb = new StringBuilder();


Convert comments in english

remiceres · 2025-11-21T13:18:31Z

...main/java/fr/inria/corese/core/next/impl/io/serialization/canonical/RDFC10Canonicalizer.java

                .toList();

-        return replaced.stream()
+        List<Statement> sorted = replaced.stream()


Immediately return this expression instead of assigning it to the temporary variable "sorted".

remiceres · 2025-11-21T13:19:26Z

src/main/java/fr/inria/corese/core/next/impl/io/parser/common/AbstractTurtleTriGListener.java

        String iri = text.substring(1, text.length() - 1);
-        return unescapeIRI(iri);
+        iri = unescapeIRI(iri);
+        return validateIRI(iri) ? iri : iri;


This conditional operation returns the same value whether the condition is "true" or "false"

remiceres · 2025-11-21T13:19:45Z

src/main/java/fr/inria/corese/core/next/impl/io/parser/common/AbstractTurtleTriGListener.java

            }

-            return resolveIRIAgainstBase(raw);
+            String result = resolveIRIAgainstBase(raw);


Immediately return this expression instead of assigning it to the temporary variable "result".

remiceres · 2025-11-21T13:22:08Z

src/main/java/fr/inria/corese/core/next/impl/common/util/IRIUtils.java

+            case '^':  // U+005E - circumflex
+            case '`':  // U+0060 - grave accent
+            case '|':  // U+007C - pipe
+            case '"':  // U+0022 - quotation mark


Merge the previous cases into this one using comma-separated label

https://next.sonarqube.com/sonarqube/coding_rules?open=java%3AS6208&rule_key=java%3AS6208

github-actions · 2025-11-21T14:34:18Z

Overall Project	50.05% `-0.13%`	🍏
Files changed	56.27%	❌

File	Coverage
RDFC10Canonicalizer.java	79.91% `-3.91%`	🍏
IRIUtils.java	60.07% `-32.36%`	❌
StatementUtils.java	52.68% `-35.42%`	❌
TriGParser.java	51.1%	🍏
TurtleParser.java	44.13%	🍏
AbstractTurtleTriGListener.java	40.96% `-4.56%`	❌

#212

github-actions · 2025-11-24T13:42:03Z

Overall Project	50.09% `-0.13%`	🍏
Files changed	52.61%	❌

File	Coverage
RDFC10Canonicalizer.java	79.91% `-3.91%`	🍏
RDFaParser.java	67.81%	🍏
IRIUtils.java	55.03% `-36.69%`	❌
StatementUtils.java	52.68% `-35.42%`	❌
TriGParser.java	51.1%	🍏
TurtleParser.java	44.13%	🍏
AbstractTurtleTriGListener.java	40.96% `-4.56%`	❌

abdessamad-abdoun added this to the V5.0.0b milestone Nov 3, 2025

abdessamad-abdoun requested review from MaillPierre and remiceres November 3, 2025 13:17

abdessamad-abdoun self-assigned this Nov 3, 2025

MaillPierre requested changes Nov 3, 2025

View reviewed changes

abdessamad-abdoun force-pushed the feature/212_Canonical_RDF branch from 6d39da7 to 951c346 Compare November 12, 2025 09:10

abdessamad-abdoun force-pushed the feature/212_Canonical_RDF branch from 951c346 to b4179c1 Compare November 17, 2025 10:45

abdessamad-abdoun force-pushed the feature/212_Canonical_RDF branch from b4179c1 to 61f9211 Compare November 18, 2025 08:20

MaillPierre force-pushed the feature/212_Canonical_RDF branch from 61f9211 to c6a90ca Compare November 19, 2025 10:08

abdessamad-abdoun force-pushed the feature/212_Canonical_RDF branch from c6a90ca to 910f540 Compare November 20, 2025 09:50

remiceres approved these changes Nov 21, 2025

View reviewed changes

abdessamad-abdoun and others added 12 commits November 24, 2025 14:14

Implement standard tests for Canonical RDF into Corese-W3C

9f89900

#212

Implement standard tests for Canonical RDF into Corese-W3C

26298fa

#212

Implement standard tests for Canonical RDF into Corese-W3C

1b2daa9

#212

plain string literal "Writer" will be serialized without the

1079434

Implement standard tests for Canonical RDF into Corese-W3C

d3b511d

#212

Implement standard tests for Canonical RDF into Corese-W3C

1c59e1e

#212

Implement standard tests for Canonical RDF into Corese-W3C

a9141f3

#212

[#212-REVUE] Implement standard tests for Canonical RDF into Corese-W3C

45805b7

[#212-REVUE] Implement standard tests for Canonical RDF into Corese-W3C

bfc8c75

fix probleme sur turtles et trig apres rebase

69cbb41

minor fix

06e1701

[#212-REVUE] Implement standard tests for Canonical RDF into Corese-W3C

70df0cf

Fixing IRIutils for compat between RDFa and RDFC

174e581

MaillPierre force-pushed the feature/212_Canonical_RDF branch from eba2902 to 174e581 Compare November 24, 2025 13:38

MaillPierre merged commit f5a22e3 into feature/corese-next Nov 24, 2025
2 checks passed

MaillPierre deleted the feature/212_Canonical_RDF branch November 24, 2025 13:42

Feature/212 canonical rdf #220

Feature/212 canonical rdf #220

Uh oh!

Conversation

abdessamad-abdoun commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 17, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

remiceres left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Nov 3, 2025 •

edited

Loading