tests: ls: add quoting-utf8 test for Unicode quotes in UTF-8 locales#243
Closed
sylvestre wants to merge 1 commit intocoreutils:masterfrom
Closed
tests: ls: add quoting-utf8 test for Unicode quotes in UTF-8 locales#243sylvestre wants to merge 1 commit intocoreutils:masterfrom
sylvestre wants to merge 1 commit intocoreutils:masterfrom
Conversation
Contributor
sylvestre
commented
Apr 6, 2026
sylvestre
commented
- tests/ls/quoting-utf8.sh: New test verifying that --quoting-style=locale and --quoting-style=clocale use Unicode left/right single quotation marks in UTF-8 locales, and that embedded apostrophes and double quotes are not escaped when the delimiters are different characters. Also checks C locale fallback to ASCII quotes.
- tests/local.mk: Add new test to the list.
* tests/ls/quoting-utf8.sh: New test verifying that --quoting-style=locale and --quoting-style=clocale use Unicode left/right single quotation marks in UTF-8 locales, and that embedded apostrophes and double quotes are not escaped when the delimiters are different characters. Also checks C locale fallback to ASCII quotes. * tests/local.mk: Add new test to the list.
pixelb
reviewed
Apr 6, 2026
| . "${srcdir=.}/tests/init.sh"; | ||
| print_ver_ ls | ||
|
|
||
| locale -a 2>/dev/null | grep -qi 'en_US\.utf' || skip_ "en_US.UTF-8 locale not available" |
Member
There was a problem hiding this comment.
That's inefficient. I'll adjust to the way we usually check this:
test "$(LC_ALL=en_US.UTF-8 locale charmap 2>/dev/null)" = UTF-8 ||
skip_ 'en_US.UTF-8 locale not available'
Member
|
Pushed in 3a9901daa |
hubot
pushed a commit
that referenced
this pull request
Apr 6, 2026
* tests/ls/quoting-utf8.sh: New test verifying that --quoting-style=locale and --quoting-style=clocale use Unicode left/right single quotation marks in UTF-8 locales, and that embedded apostrophes and double quotes are not escaped when the delimiters are different characters. Also check C locale fallback to ASCII quotes. * tests/local.mk: Reference the new test. #243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.