Skip to content

Fix helm-lint failure by creating chart template directories in sync-crds#39

Merged
Breee merged 2 commits into
mainfrom
copilot/fix-helm-lint-job
May 29, 2026
Merged

Fix helm-lint failure by creating chart template directories in sync-crds#39
Breee merged 2 commits into
mainfrom
copilot/fix-helm-lint-job

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

helm-lint failed because make sync-crds wrote generated CRD manifests into charts/drop-crds/templates/ before ensuring that directory exists in a fresh checkout. This blocked Helm lint/template steps in CI.

  • Root cause

    • sync-crds redirected output to charts/drop-crds/templates/*.yaml without creating charts/drop-crds/templates/.
  • Change

    • Updated Makefile sync-crds target to create required output directories before generating files:
      • charts/drop-crds/templates
      • charts/drop/templates
  • Code snippet

    sync-crds: manifests
    	@echo "Syncing CRDs into charts/drop-crds/templates/ and charts/drop/templates/"
    	@mkdir -p charts/drop-crds/templates charts/drop/templates
    	@for f in config/crd/bases/*.yaml; do \
    		... \
    	done
  • Resulting behavior

    • CRD sync is now robust in clean CI workspaces and no longer depends on pre-existing chart template directories.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job helm-lint Fix helm-lint failure by creating chart template directories in sync-crds May 29, 2026
Copilot finished work on behalf of Breee May 29, 2026 20:37
Copilot AI requested a review from Breee May 29, 2026 20:37
@Breee Breee marked this pull request as ready for review May 29, 2026 20:38
@Breee Breee merged commit 777271f into main May 29, 2026
5 of 6 checks passed
@Breee Breee deleted the copilot/fix-helm-lint-job branch May 29, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants