Skip to content

Bugfix/rework diffing maps #3#4

Merged
corka149 merged 20 commits intomasterfrom
bugfix/rework-diffing-maps-#3
Apr 5, 2021
Merged

Bugfix/rework diffing maps #3#4
corka149 merged 20 commits intomasterfrom
bugfix/rework-diffing-maps-#3

Conversation

@corka149
Copy link
Owner

@corka149 corka149 commented Apr 4, 2021

Jsonpatch.diff/2 create incorrect patches. In addition a lot of unnecessary strings were created and not efficient avoided.

@corka149 corka149 linked an issue Apr 4, 2021 that may be closed by this pull request
@corka149 corka149 assigned corka149 and unassigned corka149 Apr 4, 2021
@webdeb
Copy link
Contributor

webdeb commented Apr 4, 2021

@corka149 Thank you for the trust! +143 −241 👍 🎉

@webdeb
Copy link
Contributor

webdeb commented Apr 4, 2021

LGTM!

@corka149 corka149 merged commit 6ebfb99 into master Apr 5, 2021
@corka149 corka149 deleted the bugfix/rework-diffing-maps-#3 branch April 5, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

diff/2 is not returning the added map, instead its returning the key

2 participants