refactor: move loot_select info fetching to views#192
Merged
Conversation
- this is in the name of compatibility between different exts - and to reduce support time demanded by issues with that
ScuffedNewt
approved these changes
Oct 11, 2021
Contributor
ScuffedNewt
left a comment
ScuffedNewt
left a comment
There was a problem hiding this comment.
While it may not be "best practice", in common interest of maintainers and the community I feel this is a perfect solution and definitely will be a welcome one as the project expands.
Member
Author
|
I appreciate that assessment... I think it sums things up nicely. |
Draginraptor
approved these changes
Oct 14, 2021
Collaborator
Draginraptor
left a comment
Draginraptor
left a comment
There was a problem hiding this comment.
Honestly, regarding "best practice", I would've thought that this would be a good example - less code duplication, better maintainability, and is easier to expand on.
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going forward, ext authors can merely add support for a new entity to the
_loot_selectand_loot _select_rowviews... It's a "messy" fix but I think it's worthwhile.Tested locally, no further action required.