add queries/sorting to Sales#193
Merged
Merged
Conversation
…s and sort by bump, creation, or title.
itinerare
approved these changes
Oct 9, 2021
Member
itinerare
left a comment
itinerare
left a comment
There was a problem hiding this comment.
Wondering if this shouldn't go in develop, but the changes themselves look good.
Draginraptor
approved these changes
Oct 9, 2021
ScuffedNewt
approved these changes
Oct 11, 2021
preimpression
approved these changes
Oct 11, 2021
Member
|
Merging this into develop as the release branch is now closed to PRs except for those fixing breaking bugs (should they exist). |
itinerare
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add queries/sorting to sales, allowing to filter by title, by open/closed status, and to order by bump date, post date, or title.