Skip to content

feature/clear myo image#215

Merged
itinerare merged 4 commits into
lk-arpg:developfrom
itinerare:feature/clear-MYO-image
Dec 20, 2021
Merged

feature/clear myo image#215
itinerare merged 4 commits into
lk-arpg:developfrom
itinerare:feature/clear-MYO-image

Conversation

@itinerare
Copy link
Copy Markdown
Member

Adds a toggleable mini-ext to config/lorekeeper/extensions which itself adds an option when approving MYO submissions to either:

  • Do nothing
  • Hide the existing MYO placeholder image
  • Delete the existing placeholder image

Added per #182.
Tested locally, no further action required.

- toggleable in config/lorekeeper/extensions
- adds option to hide or delete MYO slot placeholder image when approving MYO submission
- also disable it by default
@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Nov 18, 2021
@itinerare itinerare added this to the v2.1.0 milestone Nov 18, 2021
@SpeedyD
Copy link
Copy Markdown
Contributor

SpeedyD commented Dec 20, 2021

I'm not an official reviewer, but I have reviewed these edits and the code seems solid to me.

@itinerare
Copy link
Copy Markdown
Member Author

@SpeedyD You can still technically review!

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Dec 20, 2021
@itinerare itinerare merged commit 3043e16 into lk-arpg:develop Dec 20, 2021
@itinerare itinerare deleted the feature/clear-MYO-image branch December 20, 2021 23:14
@itinerare itinerare linked an issue Apr 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request reviewed Pull requests that have received community review and are pending merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to have MYO image be hidden or deleted

3 participants