Skip to content

Implement PHP CS fixer#243

Merged
itinerare merged 7 commits into
lk-arpg:developfrom
itinerare:feature/php-cs-fixer
Jan 19, 2022
Merged

Implement PHP CS fixer#243
itinerare merged 7 commits into
lk-arpg:developfrom
itinerare:feature/php-cs-fixer

Conversation

@itinerare
Copy link
Copy Markdown
Member

In essence, this combs over the project's PHP files and adjusts it to suit its configuration... I've adjusted the config to hit some compromise between standards/consistency and the existing style. I think the project could stand to benefit from this kind of thing to automatically keep an eye on/enforce consistent style, given that at this point there's a good few folk that have contributed (which is great!)

Needless to say, it shouldn't actually alter any functionality. While I'm including a github action to automatically apply fixes on push/PR (so that anyone contributing doesn't necessarily need to worry overmuch, it'll just be handled), it can also be run locally with composer lint or composer sniff for a dry run.

@itinerare itinerare added the needs review Pull requests that are pending community review label Jan 19, 2022
Copy link
Copy Markdown
Collaborator

@Draginraptor Draginraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I ponder this sometimes, and absolutely love this

Copy link
Copy Markdown
Contributor

@ScuffedNewt ScuffedNewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much needed for an ever growing project and may even help newer members of the community to contribute 👍

@itinerare
Copy link
Copy Markdown
Member Author

Honestly, I ponder this sometimes, and absolutely love this

Thank you! I'm actually quite pleased with it having played around with the config... I think it'll be of help going forward too since it means there's less need to worry about getting styling Just So/can focus on content instead. ... At least for the PHP. there are solutions for other things but I haven't found one I esp like for views

@itinerare
Copy link
Copy Markdown
Member Author

much needed for an ever growing project and may even help newer members of the community to contribute +1

Would be ideal tbh, love to lower the barrier to that

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Jan 19, 2022
@itinerare itinerare merged commit 4fa3b0e into lk-arpg:develop Jan 19, 2022
@itinerare itinerare deleted the feature/php-cs-fixer branch January 19, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed Pull requests that have received community review and are pending merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants