feat: Staff Rewards#275
Merged
Merged
Conversation
- toggleable in config/lorekeeper/extensions.php - builds on admin action logging - reward is configurable per action in the admin panel - new configurable actions can be added via config file in config/lorekeeper/staff-reward-actions
Conflicts: app/Console/Kernel.php app/Services/InventoryManager.php config/lorekeeper/extensions.php resources/views/pages/credits.blade.php
Conflicts: app/Console/Kernel.php app/Helpers/Helpers.php app/Http/Controllers/Admin/Data/CharacterCategoryController.php app/Http/Controllers/Admin/HomeController.php app/Http/Controllers/Admin/SubmissionController.php app/Http/Controllers/Admin/Users/UserController.php app/Services/CharacterCategoryService.php app/Services/CharacterManager.php app/Services/CurrencyManager.php app/Services/CurrencyService.php app/Services/DesignUpdateManager.php app/Services/FeatureService.php app/Services/GalleryManager.php app/Services/GalleryService.php app/Services/InventoryManager.php app/Services/ItemService.php app/Services/ReportManager.php app/Services/Service.php app/Services/SubmissionManager.php app/Services/TradeManager.php app/Services/UserService.php config/lorekeeper/admin_sidebar.php
- prompted by staff rewards failing due to logging
itinerare
added
enhancement
Draginraptor
approved these changes
Feb 28, 2022
preimpression
approved these changes
Mar 6, 2022
itinerare
added
reviewed
tess-cos
pushed a commit
to tess-cos/lorekeeper
that referenced
this pull request
Sep 23, 2023
fix attacher() on WorldAttachment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional (configurable/toggleable in config/lorekeeper/extensions.php) extension that can automatically dispense a configurable amount of a configured currency to a staff member on them performing an action for which rewards are enabled.
Actions enabled for rewards are configured via different files in config/lorekeeper/staff-reward-actions, with each file corresponding to a different overall action (e.g. "process submission" for accepting/rejecting submissions and claims) for which staff should receive rewards. Rewards can only be dispensed for a specific action once and are broadly configured for only things that are one-time such as processing things through queues.
The amount of currency given to a staff member for performing each action can be configured via the staff rewards admin panel, accessible only to the admin rank; this also is populated via the config files via a command (
php artisan update-staff-reward-actions) which can be run manually, but also runs daily via scheduler.This builds on the earlier admin logging additions and also fixes a bug or two I encountered with that work while I was working on this. It also adds some additional logging to support staff rewards.
Tested locally/live; requires
php artisan migrate.