Skip to content

Adjustments to Admin Panel + Bugfix#30

Merged
itinerare merged 5 commits into
lk-arpg:masterfrom
preimpression:main
Nov 1, 2020
Merged

Adjustments to Admin Panel + Bugfix#30
itinerare merged 5 commits into
lk-arpg:masterfrom
preimpression:main

Conversation

@preimpression
Copy link
Copy Markdown
Contributor

Moved several category links out of the sidebar and into their target indexes (aka item categories is now a link in items) to make the sidebar a little less Tall, as well as reorganized some of the Data sidebar links by purpose (shops and currencies together, prompts and loot tables together, etc)

@preimpression preimpression changed the title Adjustments to Admin Panel Adjustments to Admin Panel + Bugfix Oct 20, 2020
@itinerare itinerare added the needs review Pull requests that are pending community review label Oct 20, 2020
Comment thread config/lorekeeper/admin_sidebar.php Outdated
'power' => 'edit_data',
'links' => [
[
'name' => 'Char. Categories',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a fan of this being the sole abbreviation of character in the sidebar

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the longest thing on the sidebar after removing Categories, it just makes the sidebar so wide haha. I can remove it if the consensus is back to normal though

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally in favour of maintaining consistency with "Character", but maybe @itinerare has an opinion? :p

Copy link
Copy Markdown
Member

@itinerare itinerare Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't personally see an issue w it but I also understand the feeling toward consistency.... I don't have a strong opinion either way though |D
If a deciding vote Is Needed, I guess I'd skew more toward consistency though

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this change @Draginraptor !

Copy link
Copy Markdown
Collaborator

@Draginraptor Draginraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking about 'Char. Categories' being the only instance of 'Character' that's abbreviated xD

Copy link
Copy Markdown
Collaborator

@Draginraptor Draginraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late reply! But yes, my desire for consistency has be satisfied :p

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Oct 31, 2020
@itinerare itinerare merged commit 47bf51a into lk-arpg:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed Pull requests that have received community review and are pending merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't remove abbreviation of existing currency when another currency exists with no abbreviation

3 participants