Skip to content

Add gift writing status to characters, etc.#33

Merged
itinerare merged 7 commits into
lk-arpg:masterfrom
itinerare:main
Nov 1, 2020
Merged

Add gift writing status to characters, etc.#33
itinerare merged 7 commits into
lk-arpg:masterfrom
itinerare:main

Conversation

@itinerare
Copy link
Copy Markdown
Member

@itinerare itinerare commented Oct 30, 2020

  • Add gift writing status to characters (yes/no/ask first)
  • Add gift writing status to bookmarks and add accompanying notification
  • Add gift writing status search to masterlist
  • Fix bug with gift art status notification
  • Add settings for:
  • Resetting character trading status, gift art status, and gift writing status on transfer (enable/disable, defaults to disabled)
  • Resetting character name and profile on transfer (enable/disable, defaults to disabled)
  • Clearing MYO slot name on MYO submission approval (enable/disable, defaults to disabled)

Requires migration, have tested locally -- settings in config/lorekeeper/settings.php

- Add gift writing status to bookmarks and add accompanying notification
- Add gift writing status search to masterlist
- Fix bug with gift art status notification
@itinerare itinerare added the needs review Pull requests that are pending community review label Oct 30, 2020
@itinerare itinerare changed the title Add gift writing status to characters Add gift writing status to characters, etc. Oct 30, 2020
@preimpression
Copy link
Copy Markdown
Contributor

Resetting should be opt-in, imo - I could see someone wanting to keep html fanciness and not realizing it'd be eaten, plus MYO names can still provide important info if, for instance, someone has submitted a handful of MYOs for approval at once.

@itinerare
Copy link
Copy Markdown
Member Author

itinerare commented Oct 31, 2020

Resetting should be opt-in, imo - I could see someone wanting to keep html fanciness and not realizing it'd be eaten, plus MYO names can still provide important info if, for instance, someone has submitted a handful of MYOs for approval at once.

Fair enough! I'm thinking maybe it might make more sense to add a setting in the config file for it? Not something you'd change often/at all after setting...

@preimpression
Copy link
Copy Markdown
Contributor

Fair enough! I'm thinking maybe it might make more sense to add a setting in the config file for it? Not something you'd change often/at all after setting...

Yeah, a config setting would work great for this! Less "omigod i'm deleting things and it's gonna break everything" for people less code-inclined who want to opt out

@itinerare
Copy link
Copy Markdown
Member Author

Yeah, a config setting would work great for this! Less "omigod i'm deleting things and it's gonna break everything" for people less code-inclined who want to opt out

Oh god, yeah, fair

Copy link
Copy Markdown
Collaborator

@Draginraptor Draginraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Nov 1, 2020
@itinerare itinerare merged commit 97f88fb into lk-arpg:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed Pull requests that have received community review and are pending merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants