Skip to content

User Profile Character/Sublist pages edited#336

Merged
itinerare merged 1 commit into
lk-arpg:developfrom
SpeedyD:develop-usercharacterspatch
Jul 1, 2022
Merged

User Profile Character/Sublist pages edited#336
itinerare merged 1 commit into
lk-arpg:developfrom
SpeedyD:develop-usercharacterspatch

Conversation

@SpeedyD
Copy link
Copy Markdown
Contributor

@SpeedyD SpeedyD commented Jul 1, 2022

  • Swapped Encoding to UTF-8 from ANSI
  • Made it look consistent with Masterlist

(PR is also possible for main branch, but I figure develop is the better call.)

- Swapped Encoding to UTF-8 from ANSI
- Made it look consistent with Masterlist
@itinerare itinerare requested a review from Draginraptor July 1, 2022 12:59
@itinerare itinerare added the needs review Pull requests that are pending community review label Jul 1, 2022
Copy link
Copy Markdown
Member

@itinerare itinerare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could potentially be a matter of opinion, but I like the change. Folk can adjust as they see fit regardless, so!

@SpeedyD
Copy link
Copy Markdown
Contributor Author

SpeedyD commented Jul 1, 2022

Could potentially be a matter of opinion, but I like the change.

Thanks @itinerare! I hope more people will like this change, if only for the consistency. :)

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Jul 1, 2022
@itinerare itinerare merged commit 81790b7 into lk-arpg:develop Jul 1, 2022
@SpeedyD SpeedyD deleted the develop-usercharacterspatch branch July 2, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed Pull requests that have received community review and are pending merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants