Prompt permalinks#341
Merged
Merged
Conversation
itinerare
added
good first issue
Member
|
I do agree-- this is a good candidate for inclusion! |
itinerare
requested changes
Jul 13, 2022
Member
itinerare
left a comment
itinerare
left a comment
There was a problem hiding this comment.
Code broadly looks good too, just needs some minor adjustments!
Contributor
Author
|
@itinerare Changes should be up! |
itinerare
approved these changes
Jul 13, 2022
SpeedyD
approved these changes
Jul 19, 2022
Contributor
Author
|
@SpeedyD I think I nudged all the headers up by one from what is was before to fit better in the full page format. |
Contributor
@AW0005 Fair enough! I'm honestly not sure if I'll even change it back myself.. I tried it out with my browser inspector and frankly, it doesn't look that bad either. Just made me go 🤔 basically. 👍 |
itinerare
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got this as an extension right now:
http://wiki.lorekeeper.me/index.php?title=Extensions:Prompt_Permalink
But it was mentioned in discord that this would be a good candidate for including in core.