Switch to laravel/pint for formatting#348
Merged
Merged
Conversation
- effects should be consistent with php-cs-fixer as pint uses it - adjust composer scripts - remove php-cs-fixer config in favor of equiv config for pint
itinerare
added
dependencies
Draginraptor
approved these changes
Jul 24, 2022
Conflicts: composer.lock
preimpression
approved these changes
Aug 8, 2022
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's still using php-cs-fixer under the hood, so the only real functional differences for our purposes are that it's built for Laravel out of the box (so doesn't need to be configured for it) and the config file is in JSON instead. It also has a clean Laravel-style output which is a nice bonus!
Relevant changes are all in the first commit; the rest is just running it w some settings updates that stood out when I was testing.
Tested locally, plus I updated the github workflow and composer scripts appropriately and verified that those are working.