Switch art/design credits to use on-site username/ID instead of alias#37
Merged
Conversation
- Add command to convert existing character image creator aliases to on-site user IDs where possible
…out associated users to use url instead
itinerare
changed the title
…erification similar to old alias system
- Format art/design credit links using said function
- Change prettyProfileLink function to use said config/condense the code in it
| // Searching on image properties | ||
| if($request->get('species_id')) $imageQuery->where('species_id', $request->get('species_id')); | ||
| if($request->get('artists')) { | ||
| if($request->get('artist')) { |
Contributor
There was a problem hiding this comment.
Inconsistency in request for 'artist' vs 'artists'
| }); | ||
| } | ||
| if($request->get('designers')) { | ||
| if($request->get('designer')) { |
Contributor
There was a problem hiding this comment.
Inconsistency in request for 'designer' vs 'designers'
preimpression
approved these changes
Nov 14, 2020
Draginraptor
approved these changes
Nov 15, 2020
Collaborator
Draginraptor
left a comment
Draginraptor
left a comment
There was a problem hiding this comment.
Sorry that it took a while, but I think the code looks good!
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php artisan assign-art-credits-to-ids) where possible (that is, where a user exists on the site with a given alias); aliases without associated accounts are converted to urls (assumes a dA account). The "alias" column can be safely dropped after this operation, if desired.Tested locally - Requires migration