Skip to content

Extended Mentions#397

Merged
itinerare merged 9 commits into
lk-arpg:developfrom
SpeedyD:feature/mentions
Sep 13, 2022
Merged

Extended Mentions#397
itinerare merged 9 commits into
lk-arpg:developfrom
SpeedyD:feature/mentions

Conversation

@SpeedyD
Copy link
Copy Markdown
Contributor

@SpeedyD SpeedyD commented Sep 13, 2022

A small Quality of Life feature, making sure users know how to use the character mention.
Also added a mention for character thumbnails, as well as adding new user mentions, including avatars this time.

SpeedyD and others added 9 commits September 13, 2022 17:07
(And fixed a minor mistake in the comment text.)
This tab is in the image section and will not show up on the Images page, only the Information page.
(Thanks to @itinerare for giving me some ideas here as well as help on the Controller var.)
Wanted to have the alt text be 'Thumbnail of CHARACTER'. Helps with screenreaders, after all.
Shoves comments aside a little bit, but there really was no good place to put this otherwise.
The permalinks are meant to be mostly for admin use, so it's hidden in a footer.
@itinerare itinerare added the needs review Pull requests that are pending community review label Sep 13, 2022
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Sep 13, 2022
@itinerare itinerare merged commit 830957e into lk-arpg:develop Sep 13, 2022
@SpeedyD SpeedyD deleted the feature/mentions branch September 13, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed Pull requests that have received community review and are pending merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants