Extended Mentions#397
Merged
Merged
Conversation
(And fixed a minor mistake in the comment text.)
This tab is in the image section and will not show up on the Images page, only the Information page. (Thanks to @itinerare for giving me some ideas here as well as help on the Controller var.)
Wanted to have the alt text be 'Thumbnail of CHARACTER'. Helps with screenreaders, after all.
Shoves comments aside a little bit, but there really was no good place to put this otherwise. The permalinks are meant to be mostly for admin use, so it's hidden in a footer.
itinerare
approved these changes
Sep 13, 2022
preimpression
approved these changes
Sep 13, 2022
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small Quality of Life feature, making sure users know how to use the character mention.
Also added a mention for character thumbnails, as well as adding new user mentions, including avatars this time.