Feat(site): Modifying pagination to allow page select on ...#614
Merged
Conversation
itinerare
reviewed
Jun 3, 2023
itinerare
approved these changes
Jun 3, 2023
Contributor
Author
|
Moif cleaned up the code extremely well, so I just added credits. |
didn't intend to when it was just me, but Moif deserves this
SpeedyD
changed the title
preimpression
approved these changes
Jun 4, 2023
Contributor
preimpression
left a comment
preimpression
left a comment
There was a problem hiding this comment.
Could do with a toggle for whether the three dots separator has the popover, but regardless looks good
Member
|
I think it's both unobtrusive and useful enough that it's fine to just have by default. |
itinerare
approved these changes
Jun 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All this PR does so far is replace the bootstrap defaults with.. the same views from the vendor.However, that makes it accessible to modify, which was the goal.As of commit 43681fc, each '...' block now opens a popover where you can change the page.
The functionality itself wasn't too bad, but the fact that each popover had to be unique.. whew.