fix(mobile): Various mobile improvements#727
Merged
Merged
Conversation
…ist search box on mobile + makes traits more legible
…s from overflowing out the layout
… & tablet friendly + adjusts the comment mention box so it isn't squished
…ader and main content + fixing the mobile sidebar header detaching from the main nav on tablets
ScuffedNewt
approved these changes
Nov 14, 2023
Contributor
ScuffedNewt
left a comment
There was a problem hiding this comment.
please merge asap ty xxxx
itinerare
approved these changes
Nov 14, 2023
Member
|
Looks like there's a conflict kicking around somewhere? But otherwise this looks good! Thanks for taking the time to put this together, too. |
Author
|
There we go, conflict dealt with! :] If I come across more mobile tweaks in the future I'll be sure to bundle 'em up and PR. |
Member
|
Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Hope I'm doing this right...! This is like my third time ever making a PR so let me know if I should be doing anything differently...)
A few various little mobile tweaks that I've put together while working on site layouts. The smallest screen size I've tested all of these on is 360px - which is generally the smallest common smartphone width these days - but they should be fine on 320px (the size of an iPhone 5/iPod Touch) as well.
An overview of the changes (with visuals):
Masterlist Search Box
Original // Modified
Gives certain fields a set width property so that they don't overflow out of the box on smaller screens, as well as adjusting the columns for trait rows so that they aren't so squished and are more legible on smaller viewports. I also gave the rarity field a slightly adjusted right margin so that rarity and species fields aren't stuck together on mobile.
Character Profiles
Removed the set max-height and max-width on the character's image and instead replaced it with the img-fluid class so that larger images stop overflowing the site's layout.
User Profiles
Original // Modified
I've recoded the top of user profiles - while keeping it as identical looking as I can - so that the avatar is no longer floating and instead the avatar and information are within responsive rows. They're also centered so it looks nicer. This should fix avatars/usernames formatting weirdly based on username length. Information rows and columns have also been adjusted slightly so that text stops overlapping each other on certain viewports. I've also given the column for the comment mention box a breakpoint so it isn't so squished and elongated on mobile.
Mobile Layout (Headers)

Adjusted the CSS very slightly so that there is now no longer a blank space between the mobile sidebar header and main content, as well as fixing an issue on tablet screens where the mobile sidebar header would detach itself from beneath the navigation bar.
Note that with long usernames, or on navbars that have extra links/dropdowns, there will still be a few pixels (nearing the 767px mark in width) where the navigation bar will slightly overlap the mobile sidebar header (this is due to the navbar's contents being too long and pushing content down, causing a taller navbar). A fix for that would be to adjust the navigation bar's overall expand breakpoint to lg, but I've left that alone as it's largely a case-by-case issue based on individual navbar content and usernames.