feature/laravel 10#746
Merged
Merged
Conversation
itinerare
added
dependencies
ScuffedNewt
approved these changes
Dec 14, 2023
SpeedyD
approved these changes
Dec 14, 2023
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to Laravel 10 so that we don't need to worry about it later/we have some breathing room there. It supports PHP 8.1 at minimum anyhow, so no action needed with regards to that.
I poked around and ran into a few issues (that I've fixed here), namely:
orderByRaw()setup for ordering character features was throwing an error, and otherwise stood to be condensed, so I reworked it a bitOtherwise a fairly uneventful upgrade, though I'm sure there's something I could have missed.