Allow for removal of last power on a rank#790
Merged
Conversation
itinerare
added
bug
itinerare
approved these changes
Jan 9, 2024
Member
itinerare
left a comment
itinerare
left a comment
There was a problem hiding this comment.
Someday we'll manage to squash all of this kind of bug...
SpeedyD
approved these changes
Jan 10, 2024
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered today that if you add a power to a rank, and it's the only power, and you try to remove it, it doesn't remove, because the code that deletes the old powers was only happening if at least one other power was being specified.