Bug(Shops): Round up shop purchase quantity#829
Merged
Conversation
itinerare
added
bug
itinerare
approved these changes
Feb 9, 2024
SpeedyD
approved these changes
Feb 10, 2024
Contributor
SpeedyD
left a comment
SpeedyD
left a comment
There was a problem hiding this comment.
Seems good to me. But should this not be in release, rather than main??
Member
|
No I ok'd it, it's all good. |
itinerare
added
reviewed
Contributor
|
I had no problem with it regardless. 👍 |
itinerare
pushed a commit
that referenced
this pull request
Feb 11, 2024
AW0005
added a commit
to AW0005/lorekeeper-extensions
that referenced
this pull request
Jun 29, 2024
* Fix(MYOs): Allows character images to work locally * fix(comments): more robust handling for non user-user comments * fix(comments): adjust staff-user default handling * fix(comments): remove empty staff-staff default * fix(items): disable box button on submit (lk-arpg#710) * fix(sales): allow setting minimum for ota and xta (lk-arpg#702) - Fixes missing minimum options for ota and xta - Also adds consistent stylization for ota and xta alongside pwyw * chore(update): 2.1.3 * hotfix(shops): round up shop purchase quantity (lk-arpg#829) * fix(shops): validate quantity against purchase limit - bump version * hotfix(security|requests): add middleware that parses post fields (lk-arpg#974) * hotfix(security|requests): add middleware that parses post fields * fix: handle arrays * fix: add "$this->" prefix to function calls * chore(update): update version * fix: add numeric check to parse to prevent dropdowns from being parsed (lk-arpg#976) * hotfix(security|requests): add middleware that parses post fields * fix: handle arrays * fix: add "$this->" prefix to function calls * fix(requests): prevent numeric value from being parsed * chore(update): update version --------- Co-authored-by: Mercury <63693594+itinerare@users.noreply.github.com> * add default criteria and currency selection --------- Co-authored-by: SpeedyD <speedydvv@gmail.com> Co-authored-by: itinerare <ad@itinerare.net> Co-authored-by: itinerare <63693594+itinerare@users.noreply.github.com> Co-authored-by: Newt <dragonminer101@gmail.com> Co-authored-by: moif <104588768+AW0005@users.noreply.github.com>
preimpression
added a commit
to preimpression/lorekeeper
that referenced
this pull request
Aug 11, 2024
* Fix(MYOs): Allows character images to work locally * fix(comments): more robust handling for non user-user comments * fix(comments): adjust staff-user default handling * fix(comments): remove empty staff-staff default * fix(items): disable box button on submit (lk-arpg#710) * fix(sales): allow setting minimum for ota and xta (lk-arpg#702) - Fixes missing minimum options for ota and xta - Also adds consistent stylization for ota and xta alongside pwyw * chore(update): 2.1.3 * hotfix(shops): round up shop purchase quantity (lk-arpg#829) * fix(shops): validate quantity against purchase limit - bump version * hotfix(security|requests): add middleware that parses post fields (lk-arpg#974) * hotfix(security|requests): add middleware that parses post fields * fix: handle arrays * fix: add "$this->" prefix to function calls * chore(update): update version * fix: add numeric check to parse to prevent dropdowns from being parsed (lk-arpg#976) * hotfix(security|requests): add middleware that parses post fields * fix: handle arrays * fix: add "$this->" prefix to function calls * fix(requests): prevent numeric value from being parsed * chore(update): update version --------- Co-authored-by: Mercury <63693594+itinerare@users.noreply.github.com> --------- Co-authored-by: SpeedyD <speedydvv@gmail.com> Co-authored-by: itinerare <ad@itinerare.net> Co-authored-by: itinerare <63693594+itinerare@users.noreply.github.com> Co-authored-by: Newt <dragonminer101@gmail.com> Co-authored-by: moif <104588768+AW0005@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because otherwise 0.5 because a whole item at half price.