fix(many): @comments overwriting scripts section#854
Merged
Conversation
Member
|
Ah. |
itinerare
approved these changes
Feb 26, 2024
itinerare
added
bug
Contributor
Author
Yeah. |
AW0005
approved these changes
Feb 26, 2024
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a problem in main, but only in release (and dev) because of the updated comments function.
Without this
@parent, many pages which have an@commentstag will find their scripts function completely non-functional, as the scripts section in the comments page just.. overrides any other.(For example: The admin side of handling reports, the Assign button did NOTHING.)