fix(world): Unhide hidden categories for appropriate staff on Universal Visual Index#874
Merged
itinerare merged 1 commit intoMar 14, 2024
Conversation
itinerare
added
bug
itinerare
approved these changes
Mar 14, 2024
AW0005
approved these changes
Mar 14, 2024
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue where hidden categories would not show up on the Species Visual Index for staff that do have the permission.. of course with appropriate fa-eye-slash marker. :)
I'd have liked to do this differently, like taking the permission from the model, but this seems to be the only way possible.
Though I distinctly count as a bug fix, as this should've been available from the get-go, the Universal Visual Index is a feature that's only on develop, and so this PR goes to develop.