add new site settings with one line instead of multiple.#89
Merged
itinerare merged 3 commits intoApr 9, 2021
Conversation
Member
|
What you have looks good! I think in the interest of reducing redundant code, though, it’d be prudent to change the existing sections adding each setting to use the new function as well. |
itinerare
approved these changes
Apr 9, 2021
preimpression
approved these changes
Apr 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site settings can be added with a single line of code instead of having to copy and modify an entire logic block.
Example:
$this->addSiteSetting("site_setting_key", 1, "0: does nothing. 1: does something.");