Skip to content

Bug(Character): Hidden characters not showing for admin#947

Merged
itinerare merged 3 commits into
lk-arpg:release/v3.0.0from
AW0005:bug-fix-character-scope-visible
May 13, 2024
Merged

Bug(Character): Hidden characters not showing for admin#947
itinerare merged 3 commits into
lk-arpg:release/v3.0.0from
AW0005:bug-fix-character-scope-visible

Conversation

@AW0005
Copy link
Copy Markdown
Contributor

@AW0005 AW0005 commented May 11, 2024

Fixes case found in the discord where if you create a Sale you can't see hidden characters despite having the appropriate permissions as an admin.

@AW0005
Copy link
Copy Markdown
Contributor Author

AW0005 commented May 11, 2024

... why did the blade formatter update the package json file

@itinerare
Copy link
Copy Markdown
Member

I think it's a weird artifact of how npm behaves or somesuch but not actually representative of any real change...

@itinerare itinerare added bug Something isn't working needs review Pull requests that are pending community review labels May 11, 2024
@itinerare
Copy link
Copy Markdown
Member

itinerare commented May 11, 2024

Anyhow, I think it'd also be prudent to go through and adjust existing queries to reflect this, but it'd probably be reasonable to do that in a separate PR/targeting develop, etc. This change on its own is kinda scooting through since it is answering a standing bug.... It's a weird case but, these things happen.

Copy link
Copy Markdown
Contributor

@SpeedyD SpeedyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure what precisely this actually fixes, but I see no problem with adding this. Useful for future development, I'm sure.

@itinerare
Copy link
Copy Markdown
Member

itinerare commented May 13, 2024

Presently the query for adding characters to sales etc. supplies the user to the visibility scope... despite that not actually being supported... so it's impossible to add hidden characters, even if you are otherwise able to see them.

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels May 13, 2024
@itinerare itinerare merged commit 18869d1 into lk-arpg:release/v3.0.0 May 13, 2024
@SpeedyD
Copy link
Copy Markdown
Contributor

SpeedyD commented May 13, 2024

Presently the query for adding characters to sales etc. supplies the user to the visibility scope... despite that not actually being supported... so it's impossible to add hidden characters, even if you are otherwise able to see them.

...I swore I fixed this prior, but I've been shown what the problem is and.. this is caused by the selectize update =_=;...

@itinerare
Copy link
Copy Markdown
Member

I mean, prior, that was intended behavior... and, to be fair, the culprit is mostly that particular scope not being consistent with most of the others within the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working reviewed Pull requests that have received community review and are pending merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants