Bug(Character): Hidden characters not showing for admin#947
Conversation
|
... why did the blade formatter update the package json file |
|
I think it's a weird artifact of how npm behaves or somesuch but not actually representative of any real change... |
|
Anyhow, I think it'd also be prudent to go through and adjust existing queries to reflect this, but it'd probably be reasonable to do that in a separate PR/targeting develop, etc. This change on its own is kinda scooting through since it is answering a standing bug.... It's a weird case but, these things happen. |
SpeedyD
left a comment
There was a problem hiding this comment.
I'm unsure what precisely this actually fixes, but I see no problem with adding this. Useful for future development, I'm sure.
|
Presently the query for adding characters to sales etc. supplies the user to the visibility scope... despite that not actually being supported... so it's impossible to add hidden characters, even if you are otherwise able to see them. |
...I swore I fixed this prior, but I've been shown what the problem is and.. this is caused by the selectize update =_=;... |
|
I mean, prior, that was intended behavior... and, to be fair, the culprit is mostly that particular scope not being consistent with most of the others within the project. |
Fixes case found in the discord where if you create a Sale you can't see hidden characters despite having the appropriate permissions as an admin.